Fix nightly by updating screenshots #8957
Conversation
📝 WalkthroughWalkthroughConverts several in-page evaluate callbacks to async, awaits API readiness, dispatches actions, and calls Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/javascripts/test/puppeteer/dtype_datasets_rendering.screenshot.ts (2)
240-247: Flatten async flow in page.evaluate (avoid mixing await with .then).Good call to await tracing.save() before proceeding. Minor clean-up: prefer a straight await chain for readability.
- await page.evaluate(async (actions) => { - await window.webknossos.apiReady().then(async () => { - for (const action of actions) { - window.webknossos.DEV.store.dispatch(action); - } - await window.webknossos.DEV.api.tracing.save(); - }); - }, actions); + await page.evaluate(async (actions) => { + await window.webknossos.apiReady(); + for (const action of actions) { + window.webknossos.DEV.store.dispatch(action); + } + await window.webknossos.DEV.api.tracing.save(); + }, actions);
286-291: Remove stray semicolon and optionally await API readiness
Delete the extra semicolon aftersave()on line 290. For consistency with the earlierpage.evaluatecall (around line 241), you can also prependawait window.webknossos.apiReady();at the top of this callback.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
frontend/javascripts/test/screenshots/2017-05-31_mSEM_aniso-test.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/ROI2017_wkw.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/ROI2017_wkw_with_mapping_astrocyte.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/annotation_ROI2017_wkw_segmentation.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/annotation_ROI2017_wkw_without_fallback.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/connectome_file_test_dataset.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/kiwi.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/test-agglomerate-file_with_mapping_link.pngis excluded by!**/*.pngfrontend/javascripts/test/screenshots/test-agglomerate-file_with_meshes_link.pngis excluded by!**/*.png
📒 Files selected for processing (1)
frontend/javascripts/test/puppeteer/dtype_datasets_rendering.screenshot.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-smoketest-push
- GitHub Check: backend-tests
| await page.evaluate((actions) => { | ||
| return window.webknossos.apiReady().then(() => { | ||
| await page.evaluate(async (actions) => { | ||
| await window.webknossos.apiReady().then(async () => { |
There was a problem hiding this comment.
The then callback actually gets api as an argument, so you could use that instead of window.webknossos.DEV.api.
…ossos into fix-nightly-25-09-26
2 participants
The default rotation in the 3d viewport changed for some reason. Also saving the annotation became necessary because changing the zoom leads to an unsaved state which left the CI hanging due to a confirm dialog. I don't know why this wasn't a problem earlier.
Steps to test: